NetBSD-Bugs archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: kern/46961: Please support BCM57762 Ethernet arapter (Apple's ThunderboltEthernet Adapter)
The following reply was made to PR kern/46961; it has been noted by GNATS.
From: Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: kern-bug-people%NetBSD.org@localhost, tsutsui%ceres.dti.ne.jp@localhost
Subject: Re: kern/46961: Please support BCM57762 Ethernet arapter (Apple's
ThunderboltEthernet
Adapter)
Date: Sun, 16 Sep 2012 19:51:45 +0900
I wrote:
> Doesn't your 57762 work without this (ETHER_MAX_DIX_LEN << 2) change?
>
> OpenBSD log says it was taken from Linux driver,
> http://www.openbsd.org/cgi-bin/cvsweb/src/sys/dev/pci/if_bge.c#rev1.28
> but probably we should check specification of the
> BGE_RX_STD_RCB_MAXLEN_FLAGS register...
Okay, there is a Programmer's Guide of 57765/57762 in
Broadcom's "Ethernet NIC Open Source Developer Resources" page:
http://ja.broadcom.com/support/ethernet_nic/open_source.php
It says bits 15:2 in the "Receive Producer Length/Flags Register"
means "Maximum Ethernet Frame Length" and the description also says
"specifies the maximum size of an Ethernet frame plus VLAN tag"
so probably
>> rcb->bge_maxlen_flags = (BGE_RCB_MAXLEN_FLAGS(512,
>> ((ETHER_MAX_LEN + ETHER_VLAN_ENCAP_LEN) << 2));
is enough, rather than indroducing unknown ETHER_MAX_DIX_LEN.
---
Izumi Tsutsui
Home |
Main Index |
Thread Index |
Old Index