Re: kern/44972: raidctl -R doesn't seem to work

[Greg Oster <oster%cs.usask.ca@localhost>]

On Wed,  3 Aug 2011 03:50:04 +0000 (UTC)
yamt%mwd.biglobe.ne.jp@localhost (YAMAMOTO Takashi) wrote:

> The following reply was made to PR kern/44972; it has been noted by
> GNATS.
> 
> From: yamt%mwd.biglobe.ne.jp@localhost (YAMAMOTO Takashi)
> To: gnats-bugs%NetBSD.org@localhost
> Cc: kern-bug-people%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
>       netbsd-bugs%netbsd.org@localhost, yamt%NetBSD.org@localhost
> Subject: Re: kern/44972: raidctl -R doesn't seem to work
> Date: Wed,  3 Aug 2011 03:46:57 +0000 (UTC)
> 
>  --Boundary-20110803124142-2676200
>  Content-Type: Text/Plain; charset=us-ascii
>  
>  > - the DIOCGPART ioctl in rf_ReconstructInPlace failed with ENOTTY
>  >   as dk doesn't support it.
>  
>  the attached patch is to fix this part of the problem.
>  can anyone please review and commit? 

Reviewed, and committed.  Thanks!

> i guess it's better to use rf_getdisksize.

I thought so too, except that rf_getdisksize() would be setting values
in the raidPtr->Disks[] array without holding the appropriate mutex.
So your fix is the better one at this point... 

Later...

Greg Oster