Re: port-xen/40675: Xen 3.3: guest serial console not functional

["Christoph Egger" <Christoph_Egger%gmx.de@localhost>]

The following reply was made to PR port-xen/40675; it has been noted by GNATS.

From: "Christoph Egger" <Christoph_Egger%gmx.de@localhost>
To: gnats-bugs%NetBSD.org@localhost, netbsd-bugs%netbsd.org@localhost, 
gnats-admin%netbsd.org@localhost,
 port-xen-maintainer%netbsd.org@localhost
Cc: 
Subject: Re: port-xen/40675: Xen 3.3: guest serial console not functional
Date: Fri, 20 Feb 2009 14:56:51 +0100

 Nope, that doesn't fix it.
 
 With help from uebayasi, I found the issue yesterday
 and the fix is upstream now:
 
 http://xenbits.xensource.com/staging/xen-3.3-testing.hg?rev/39c14827be55
 
 xenconsoled: make guest console visible on NetBSD dom0
 
 After openpty(), slave_fd must be closed or guest console output
 goes to the slave while select() in xen console client listens on
 the master.
 
 --- a/tools/console/daemon/io.c        Fri Feb 20 11:44:27 2009 +0000
 +++ b/tools/console/daemon/io.c        Fri Feb 20 11:44:58 2009 +0000
 @@ -420,6 +420,14 @@ static int domain_create_tty(struct doma
                goto out;
        }
  
 +      /* Close the slave fd or the guest console output disappears,
 +       * otherwise.
 +       */
 +      if (dom->slave_fd != -1) {
 +              close(dom->slave_fd);
 +              dom->slave_fd = -1;
 +      }
 +
        if (dom->use_consolepath) {
                success = asprintf(&path, "%s/limit", dom->conspath) !=
                        -1;
 
 
 -- 
 Greetings,
 
 Christoph