kern/40431: recent fxp change broke my fxp

[yamt%mwd.biglobe.ne.jp@localhost]

>Number:         40431
>Category:       kern
>Synopsis:       recent fxp change broke my fxp
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jan 19 03:40:00 +0000 2009
>Originator:     YAMAMOTO Takashi <yamt%mwd.biglobe.ne.jp@localhost>
>Release:        NetBSD 5.99.7
>Organization:
        
>Environment:
        
        
Architecture: i386
Machine: i386
>Description:
        after the recent fxp driver changes,
        dhcpcd says "timeout" on my fxp0.

        fxp0 at pci1 dev 8 function 0: Intel PRO/100 VE (MOB) Network 
Controller, rev 131
        fxp0: interrupting at irq 11
        fxp0: Ethernet address 00:0e:7b:f9:87:20
        inphy0 at fxp0 phy 1: i82562ET 10/100 media interface, rev. 0
        inphy0: 10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, auto

>How-To-Repeat:
>Fix:
        reverting the following changes fixes the problem.

        > Subject: CVS commit: src/sys/dev
        > From: matthew green <mrg%netbsd.org@localhost>
        > To: source-changes%NetBSD.org@localhost
        > Date: Sun, 18 Jan 2009 10:37:04 +0000 (UTC)
        > Reply-To: mrg%netbsd.org@localhost
        > 
        > 
        > Module Name:  src
        > Committed By: mrg
        > Date:         Sun Jan 18 10:37:04 UTC 2009
        > 
        > Modified Files:
        >       src/sys/dev/cardbus: if_fxp_cardbus.c
        >       src/sys/dev/ic: i82557.c i82557var.h
        >       src/sys/dev/mii: inphy.c
        >       src/sys/dev/pci: if_fxp_pci.c
        > 
        > Log Message:
        > The PCI revision numbers are unique to a PCI vendor/product
        > ID pair.  Misuse of the revision numbers was causing some of the chip
        > features to be disabled on some integrated Intel chips.  So, move the
        > determination of the features into the bus frontend, where the
        > vendor/product ID is known.  (Note: sc_rev should be removed.  The
        > microcode patch stuff is also busted and needs to be fixed.)  Also,
        > poll the actual flow control status in inphy, rather than making
        > assumptions.
        > 
        > contributed anonymously.
        > 
        > 
        > To generate a diff of this commit:
        > cvs rdiff -r1.34 -r1.35 src/sys/dev/cardbus/if_fxp_cardbus.c
        > cvs rdiff -r1.121 -r1.122 src/sys/dev/ic/i82557.c
        > cvs rdiff -r1.41 -r1.42 src/sys/dev/ic/i82557var.h
        > cvs rdiff -r1.49 -r1.50 src/sys/dev/mii/inphy.c
        > cvs rdiff -r1.60 -r1.61 src/sys/dev/pci/if_fxp_pci.c
        > 
        > Please note that diffs are not public domain; they are subject to the
        > copyright notices on the relevant files.

>Unformatted: