Re: kern/39094 (Add et (Agere ET1310/ET1301) network driver to NetBSD)

[Kaspar Brand <netbsd+gnats%velox.ch@localhost>]

The following reply was made to PR kern/39094; it has been noted by GNATS.

From: Kaspar Brand <netbsd+gnats%velox.ch@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: jnemeth%NetBSD.org@localhost
Subject: Re: kern/39094 (Add et (Agere ET1310/ET1301) network driver to NetBSD)
Date: Tue, 06 Jan 2009 20:30:38 +0100

 John Nemeth wrote:
 >  }  Finally, a last thing to note: I changed the device ID for the
 >  }  ET1301 controller on purpose - according to the data sheet, it's
 >  }  0xed01, not 0xed0a (as in the DragonFly/OpenBSD sources). I can't
 >  }  verify with a real controller, however, since I only have a system
 >  }  with an ET1310.
 >  
 >       Data sheets can be and are often wrong.  Can you check with some
 >  of the other people that have this driver to see if there is a reason
 >  for the discrepancy (such as empirical testing), please?
 
 Sorry, I was mixing things up - I changed the *description* of the
 controller in pcidevs (to "1301", as that's the correct identifier for
 the Fast Ethernet version). The device ID must be 0xed01 in any case, cf.
 
 
http://gitweb.dragonflybsd.org/?p=dragonfly.git;a=commitdiff;h=9852a485af9827da5130a97f18c9124248c25555
 
 and
 
 
http://www.openbsd.org/cgi-bin/cvsweb/src/sys/dev/pci/pcidevs.diff?r1=1.1195;r2=1.1196
 
 (it's also what you find in the Linux and Windows drivers from Agere
 itself). I assume it was a typo when you originally committed these changes.