Re: kern/39960: Enhanced Speedstep module patch

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

On Wed, Nov 19, 2008 at 10:05:00PM +0000, xtraeme%gmail.com@localhost wrote:
> The Intel Enhanced Speedstep code is enabled by default on x86 GENERIC
> kernels. I propose the following patch that autoloads the module only
> if EST CPUID feature is available and enabled, as currently done in
> x86/identcpu.c.
> 
> Some stuff I have done in the patch:
> 
> - Removed EST_FREQ_USERWRITE completely... who really uses this and
>   why is this useful? root should be the only one allowed, IMHO.
> - Removed RUN_ONCE(9) stuff, it's completely unused now.
> - Removed support to make this build in the kernel. Some modules are
>   now autoloaded too, I wanted to follow this behaviour...

Do you mean that with your patch, it's not possible to build a non-MODULAR
kernel with Enhanced Speedstep ? that's not acceptable.
We want to still provide a way to build monolitic kernels, even if it's not
the default.

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--