NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

kern/39960: Enhanced Speedstep module patch



>Number:         39960
>Category:       kern
>Synopsis:       Enhanced Speedstep module patch
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Wed Nov 19 22:05:00 +0000 2008
>Originator:     Juan RP
>Release:        Latest
>Organization:
>Environment:
NetBSD vmware-netbsd 5.99.3 NetBSD 5.99.3 (MASTER) #8: Wed Nov 19 22:20:25 CET 
2008  juan@vmware-netbsd:/home/juan/build/obj/sys/arch/i386/compile/MASTER i386
>Description:
The Intel Enhanced Speedstep code is enabled by default on x86 GENERIC
kernels. I propose the following patch that autoloads the module only
if EST CPUID feature is available and enabled, as currently done in
x86/identcpu.c.

Some stuff I have done in the patch:

- Removed EST_FREQ_USERWRITE completely... who really uses this and
  why is this useful? root should be the only one allowed, IMHO.
- Removed RUN_ONCE(9) stuff, it's completely unused now.
- Removed support to make this build in the kernel. Some modules are
  now autoloaded too, I wanted to follow this behaviour...

I haven't tested the patch with real hardware (ENOHW), anyway I
wouldn't expect any problem unless I missed something.
>How-To-Repeat:

>Fix:
I will send the patch in some minutes.



Home | Main Index | Thread Index | Old Index