Re: kern/39812: uberry(4) sends continuous messages to the console

["David H. Gutteridge" <dhgutteridge%sympatico.ca@localhost>]

The following reply was made to PR kern/39812; it has been noted by GNATS.

From: "David H. Gutteridge" <dhgutteridge%sympatico.ca@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: kern/39812: uberry(4) sends continuous messages to the console
Date: Mon, 27 Oct 2008 20:01:01 -0500

 "Jared D. McNeill" <jmcneill%invisible.ca@localhost> wrote:
 >  Please try the following change:
 >
 >  Index: uberry.c
 >  ===================================================================
 >  RCS file: /cvsroot/src/sys/dev/usb/uberry.c,v
 >  retrieving revision 1.3
 >  diff -u -p -r1.3 uberry.c
 >  --- uberry.c        26 May 2008 03:20:56 -0000      1.3
 >  +++ uberry.c        27 Oct 2008 11:11:06 -0000
 >  @@ -114,7 +114,8 @@ uberry_charge(struct uberry_softc *sc)
 >      char dummy[2];
 >      usbd_status err;
 >
 >  -   if (sc->sc_udev->power != USB_MAX_POWER) {
 >  +   aprint_debug_dev(sc->sc_dev, "charging at %dmA\n", sc->sc_udev->power);
 >  +   if (sc->sc_udev->power < USB_MAX_POWER / 2) {
 >              uberry_cmd(sc, UT_READ | UT_VENDOR, 0xa5, 0, 1, dummy, 2);
 >              uberry_cmd(sc, UT_WRITE | UT_VENDOR, 0xa2, 0, 1, dummy, 0);
 >      }
 
 I still encounter the same issue:
 
 uberry0 at uhub0 port 1
 uberry0: Research In Motion BlackBerry, rev 1.10/1.04, addr 2
 uberry0: at uhub0 port 1 (addr 2) disconnected
 uberry0: detached
 uberry0 at uhub0 port 1
 uberry0: Research In Motion BlackBerry, rev 1.10/1.04, addr 2
 uberry0: at uhub0 port 1 (addr 2) disconnected
 uberry0: detached
 (etc., etc.)
 
 (Though I see there's a subtle difference in the output, there's no
 "Oct 27 00:14:10 arcusv /netbsd:" line with nothing after it anymore.)
 
 So it looks like it isn't getting to uberry_charge().  I'll try
 recompiling the kernel with UBERRY_DEBUG enabled and DIAGNOSTIC for
 good measure, maybe that will prove useful.
 
 Regards,
 
 Dave