Re: kern/39812: uberry(4) sends continuous messages to the console

["Jared D. McNeill" <jmcneill%invisible.ca@localhost>]

The following reply was made to PR kern/39812; it has been noted by GNATS.

From: "Jared D. McNeill" <jmcneill%invisible.ca@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: kern-bug-people%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, 
 netbsd-bugs%netbsd.org@localhost
Subject: Re: kern/39812: uberry(4) sends continuous messages to the console
Date: Mon, 27 Oct 2008 07:11:31 -0400

 David H. Gutteridge wrote:
 >> How-To-Repeat:
 > Attach a BlackBerry 7250 to a machine running a kernel with the
 > uberry(4) device included.
 
 Please try the following change:
 
 Index: uberry.c
 ===================================================================
 RCS file: /cvsroot/src/sys/dev/usb/uberry.c,v
 retrieving revision 1.3
 diff -u -p -r1.3 uberry.c
 --- uberry.c   26 May 2008 03:20:56 -0000      1.3
 +++ uberry.c   27 Oct 2008 11:11:06 -0000
 @@ -114,7 +114,8 @@ uberry_charge(struct uberry_softc *sc)
        char dummy[2];
        usbd_status err;
 
 -      if (sc->sc_udev->power != USB_MAX_POWER) {
 +      aprint_debug_dev(sc->sc_dev, "charging at %dmA\n", sc->sc_udev->power);
 +      if (sc->sc_udev->power < USB_MAX_POWER / 2) {
                uberry_cmd(sc, UT_READ | UT_VENDOR, 0xa5, 0, 1, dummy, 2);
                uberry_cmd(sc, UT_WRITE | UT_VENDOR, 0xa2, 0, 1, dummy, 0);
        }