Re: VirtualBox guest additions build failure

[Chavdar Ivanov <ci4ic4%gmail.com@localhost>]

On Wed, 28 Apr 2021 at 15:43, Jason Thorpe <thorpej%me.com@localhost> wrote:
>
>
> > On Apr 28, 2021, at 1:11 AM, Chavdar Ivanov <ci4ic4%gmail.com@localhost> wrote:
> >
> > --- src/VBox/Additions/common/VBoxGuest/VBoxGuest-netbsd.c.ORIG
> > 2021-04-28 08:30:19.546105988 +0100
> > +++ src/VBox/Additions/common/VBoxGuest/VBoxGuest-netbsd.c
> > 2021-04-28 08:35:01.833286272 +0100
> > @@ -416,7 +416,12 @@
> >     if (RT_FAILURE(rc))
> >         goto fail;
> >
> > +
> > +#if __NetBSD_Version__ >= 999008200
> > +    config_found(sc->sc_dev, &am, wsmousedevprint, CFARG_IATTR,
> > "wsmouswdev", CFARG_EOL);
> > +#else
> >     sc->sc_wsmousedev = config_found_ia(sc->sc_dev, "wsmousedev",
> > &am, wsmousedevprint);
> > +#endif
> >     if (sc->sc_wsmousedev == NULL)
> >         goto fail;
> >
> >
> > got me a panic; the crash dump was apparently taken, but savecore
> > didn't find anything. I am in a hurry and have no time at the moment
> > to transcribe the output, but as the png files are small, so I am
> > attaching them.
>
> That's because there's a typo ... "wsmouswdev" is not "wsmousedev".  If you attempt to attach children with an interface attribute the device doesn't carry, that is also an error that a KASSERT() will fire on.

Thick fingers... w next to e... In my excuse, I had 15 minutes between
receiving the mail with the suggested patch and leaving for a
customer.

Anyway, thanks; now works as before (the daemon still exits but the
reason is different, as before -

10:19:44.965506 main     VBoxService 6.1.20 r143896 (verbosity: 0)
netbsd.amd64 (Apr 27 2021 21:25:13) release log
10:19:44.965518 main     Log opened 2021-04-28T10:19:44.965483000Z
10:19:44.965951 main     OS Product: NetBSD
10:19:44.965994 main     OS Release: 9.99.82
10:19:44.966011 main     OS Version: NetBSD 9.99.82 (GENERIC_KASLR)
#0: Mon Apr 26 04:13:54 BST 2021
sysbuild@ymir:/home/sysbuild/amd64/obj/home/sysbuild/src/sys/arch/amd64/compile/GENERIC_KASLR
10:19:44.966026 main     Executable: /usr/local/bin/additions/VBoxService
10:19:44.966033 main     Process ID: 14065
10:19:44.966041 main     Package type: BSD_64BITS_GENERIC
10:19:44.966110 main     Error: Failed to connect to the guest
property service! Error: VERR_NOT_SUPPORTED
10:19:44.966128 main     Error: Service 'timesync' failed pre-init:
VERR_NOT_SUPPORTED

But Xorg works as expected.

>
> Honestly, if the parent device in question only has a single interface attribute (I don't know because I haven't looked at the VirtualBox code), then the best choice is to simply omit it from the config_found() call.
>
> -- thorpej
>


-- 
----