Current-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: VirtualBox guest additions build failure



> On Apr 28, 2021, at 1:11 AM, Chavdar Ivanov <ci4ic4%gmail.com@localhost> wrote:
> 
> --- src/VBox/Additions/common/VBoxGuest/VBoxGuest-netbsd.c.ORIG
> 2021-04-28 08:30:19.546105988 +0100
> +++ src/VBox/Additions/common/VBoxGuest/VBoxGuest-netbsd.c
> 2021-04-28 08:35:01.833286272 +0100
> @@ -416,7 +416,12 @@
>     if (RT_FAILURE(rc))
>         goto fail;
> 
> +
> +#if __NetBSD_Version__ >= 999008200
> +    config_found(sc->sc_dev, &am, wsmousedevprint, CFARG_IATTR,
> "wsmouswdev", CFARG_EOL);
> +#else
>     sc->sc_wsmousedev = config_found_ia(sc->sc_dev, "wsmousedev",
> &am, wsmousedevprint);
> +#endif
>     if (sc->sc_wsmousedev == NULL)
>         goto fail;
> 
> 
> got me a panic; the crash dump was apparently taken, but savecore
> didn't find anything. I am in a hurry and have no time at the moment
> to transcribe the output, but as the png files are small, so I am
> attaching them.

That's because there's a typo ... "wsmouswdev" is not "wsmousedev".  If you attempt to attach children with an interface attribute the device doesn't carry, that is also an error that a KASSERT() will fire on.

Honestly, if the parent device in question only has a single interface attribute (I don't know because I haven't looked at the VirtualBox code), then the best choice is to simply omit it from the config_found() call.

-- thorpej



Home | Main Index | Thread Index | Old Index