Re: npf build break

[Mindaugas Rasiukevicius <rmind%netbsd.org@localhost>]

Valery Ushakov <uwe%stderr.spb.ru@localhost> wrote:
> > > 
> > > uint16_t bswap16(uint16_t) __constfunc;
> > >                        -> __attribute__((__const__))
> > > 
> > 
> > This code has been for years.  Are you building with -O0 option?
> 
> May be we shouldn't depend on the optimizer to take care of this?
> Should we provide suitable macros, say, HTONS_C(val) and HTONL_C(val)
> using C99 INT*_C() macros as a naming pattern?  __byte_swap_*_constant
> may not be directly suitable for this as they include a cast which
> precludes its use in preprocessor directives (assuming that's a
> desirable feature).

I agree.  Would you like to add them?

-- 
Mindaugas