tech-userlevel archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Addition of ppoll(2), a wrapper around pollts(2)

On 25.05.2020 13:15, Joerg Sonnenberger wrote:
> On Mon, May 25, 2020 at 12:05:44PM +0200, Martin Husemann wrote:
>> On Mon, May 25, 2020 at 03:09:09PM +0530, Apurva Nandan wrote:
>>> I meant that I can't create a __weak_alias ppoll(2) to pollts(2) in libc as
>>> pollts(2) has its definition in sys/sys. But yes the resulting weak alias
>>> symbol works from everywhere.
>> The syscall stabs are generated code, but we have full controll over the
>> generator, so adding a variant with an aliased name should be simple.
> I don't see any reason to micro-optimize a tail call here.
> Joerg

I agree here with Joerg.

At this point it's good to just add a wrapper as in the proposed patch.
Once we will bump libc major, we can rename the syscall and remove
pollts references.

Weak alias would still be nicer, but it might be not worth the
complexity of tweaking the syscall stab code generation.

I think it's good to test t_pollts and t_ppoll as in theory they are
different APIs. Long term t_pollts can be removed, after libc major bump.

Attachment: signature.asc
Description: OpenPGP digital signature

Home | Main Index | Thread Index | Old Index