Re: colorls in base

[christos%astron.com@localhost (Christos Zoulas)]

In article <201902150226.x1F2QT6R003290%server.cornerstoneservice.ca@localhost>,
John Nemeth  <jnemeth%cue.bc.ca@localhost> wrote:
>On Feb 15, 10:56am, Rin Okuyama wrote:
>} 
>} I'd like to propose to introduction -G (colorized output) option
>} to ls(1), which is compatible to FreeBSD and macOS:
>} 
>} http://www.netbsd.org/~rin/colorls-20190215.patch
>} 
>} I know that we already have misc/colorls in pkgsrc. In the era of
>
>-1   we don't need this kind of annoying crap in base.

While this is you opinion and you have every right to it, you need
to provide a technical reason to substantiate it. For example: the
code is intrusive/poorly implemented, the feature can confuse piped
output to programs, you can't turn it off, it is bloat, it goes
contrary to the Unix philosophy etc.

Without an explanation a comment like this has negative value in
our lists: it can make the author feel bad and does not help the
rest of the audience decide on technical merit about this feature.

Like it or not, some people find color helpful; in ls(1), in vi(1),
in other parts of the system...

I think that the code is well-written and the feature is well-document,
and I would opine that the feature should be included. I don't like
the amount of ifdefs (I could prefer some of the inline code to go
to a function). But the rest seems fine to me and thanks Rin for
working on it.

christos