tech-userlevel archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: terminfo implementation

Christos Zoulas wrote:
In article <>,
Roy Marples  <> wrote:
Christos Zoulas wrote:
        - there are more baud rates defined on NetBSD.
        - the arrays of constants should be sorted so the index functions
          can use binary search instead of of linear.
        - use errx(3) in the exit case so that the program name gets printed.
        - what frees tp->_extras?
        - sort arrays and use binary search.
        - to support multiple terminals outc should be passed a second
          void * argument that can be used from the application to determine
          the terminal context. ie. the signature for ti_puts should be
int ti_puts(const TERMINAL *term, const char *str, int affcnt, int (*outc)(int, void *), void *arg)
OK, new snapshot with all the above changes done.

I generate hash tables for terminfo and termcap strings now.

Looks good. I would not bother duplicating the functions in tputs.c. I would
just cast putchar to (int (*)(int, void *)) and pass NULL as the argument.

Done. I've also renamed tparmv to vtparm so the naming follows other variadic functions.
I've refreshed the tarball.

I've also tested this against tmux on Sparc64 where it works equally well and compiles without warnings, so looking good :)



Home | Main Index | Thread Index | Old Index