Re: Final distfile argmax fix

[Jonathan Perkin <jperkin%mnx.io@localhost>]

* On 2024-10-15 at 13:43 BST, Taylor R Campbell wrote:

> > Date: Tue, 15 Oct 2024 11:47:35 +0100
> > From: Jonathan Perkin <jperkin%mnx.io@localhost>
> >
> > A while back I posted a patch to correctly handle wip/grafana which now
> > has so many distfiles it breaks both make and checksum.awk.
> >
> > I've revisited the patch, cleaned it up a bit further, made it more
> > generic, and also made it work with the mktool patch for fetch, as that
> > also now requires temporary files if using an older make.
> >
> > The current patch for review is here:
> >
> >    https://github.com/NetBSD/pkgsrc/commit/fa88ed98c9db92f637ce54ce71c85cfc253063a3
>
> Cool!  Tiny suggestion: Can you put some additional information in the
> temp file name, for attribution?  E.g., maybe `pkgsrc' and the package
> name?  That will make it easier to track down unexplained files in
> /tmp if anything is interrupted before the rm.

Sure, good idea.

> (Or, is there a reason it needs to be in /tmp and not in $WRKDIR?)

WRKDIR is not guaranteed to exist (it won't for the distinfo targets).

Thanks,

--
Jonathan Perkin   -   mnx.io   -   pkgsrc.smartos.org
Open Source Complete Cloud   www.tritondatacenter.com