tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Final distfile argmax fix



* On 2024-10-15 at 14:20 BST, Taylor R Campbell wrote:

Date: Tue, 15 Oct 2024 14:18:29 +0100
From: Jonathan Perkin <jperkin%mnx.io@localhost>

* On 2024-10-15 at 13:43 BST, Taylor R Campbell wrote:

>(Or, is there a reason it needs to be in /tmp and not in $WRKDIR?)

WRKDIR is not guaranteed to exist (it won't for the distinfo targets).

Makes sense, could you add a comment noting this (if I didn't just
miss one that's already there)?

Yep, sounds good, I just committed this:

  https://github.com/NetBSD/pkgsrc/commit/d16486e39b431a1d490ffe62f52eb064f377a369

which also uses TMPDIR if set.

I also pushed this minor change:

  https://github.com/NetBSD/pkgsrc/commit/ca6d94fd8274fdb534b202cbe395f4295baf126d

to simplify some of the logic.

Thanks,

--
Jonathan Perkin   -   mnx.io   -   pkgsrc.smartos.org
Open Source Complete Cloud   www.tritondatacenter.com


Home | Main Index | Thread Index | Old Index