tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: gcc.mk: adjusting charconv to follow the limited-versions guidance



* On 2024-10-14 at 19:51 BST, Greg Troxel wrote:

As part of the USE_CXX_FEATURES scheme (yay, and thanks nia@ for leading
it), we have a plan to require a limited set of compilers aligned with
NetBSD releases, e.g. to avoid building gcc 8, 9, and 10 on a system
with 7 in base, when just building 10 would be better.

This plan is mostly followed, but not quite.  The following change would
follow it harder, and align charconv with filesystem and paralellism_ts.
My view is that there is no good reason it's set to 8 now, other than
the history of how we got here (using 8 dates from the grand rototill to
USE_CXX_FEATURES).

I believe that fixing this results in choosing 10 instead of 8 on NetBSD
9, and thus removing a reason why gcc8 is built, instead of just having
10.  I've been carrying this as a local patch for a while with no ill
effects, and the comment asking for an explanation has been there since
June.

I'll commit this in a few days absent objections with rationale.  If you
object, please provide rationale for one of:

Just for the record, I do not like the way that NetBSD-specific versioning is being hard-coded in a platform-agnostic file. This may well be improving the situation on NetBSD, but making it worse on a different platform with different GCC versions in its base system (for example if it ships GCC 9 but now has a dependency on GCC 10 even though its native GCC 9 is absolutely fine).

This kind of information should really be done in mk/platform, ideally with:

* gcc.mk containing the documented versions of when a particular feature was added to GCC.

* platform/OPSYS.mk overriding versions as necessary to accommodate what is available on the platform.

This isn't an objection to your patch specifically, given that it just follows what is already in place, but I would like what is in place to be done properly at some point.

--
Jonathan Perkin   -   mnx.io   -   pkgsrc.smartos.org
Open Source Complete Cloud   www.tritondatacenter.com


Home | Main Index | Thread Index | Old Index