tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: checksum argmax fix



On Wed, 7 Aug 2024 at 10:12, Jonathan Perkin <jperkin%mnx.io@localhost> wrote:
>
> * On 2024-08-07 at 07:40 BST, Thomas Klausner wrote:
>
> >Other ideas?
>
> The only option I can see that would make grafana work with older bmake
> is to change the checksum target to create a temporary file in /tmp to
> hold the list of files.  I really don't like this option though:
>
>   * I think we'd need to grow a dependency on mktemp or similar.  Given
>     this is our fundamental checksum verification stage I am really
>     uncomfortable with it relying on world-writeable directories.
>
>   * It would negatively impact performance for every package.
>
> I'm happy with saying that if folks want to build newer grafana's they
> need a newer bmake.  I'm not aware of any other packages that are yet
> close to the argmax limit, so we could even add a dependency on the
> required bmake version in grafana itself.  If other packages start
> showing up then we can move the logic to mk.

I like this approach - feels like the least awkward option, and can be
built upon if needed again in future.

Presumably we can rely on the internal version for any bmake, which
would allow people running netbsd-9 and netbsd-10 stable branches to
have it Just Work if bmake pullups are done. Plus the Automated pkgsrc
commit testing rig could flag any package which needs it but is
missing :-p

David


Home | Main Index | Thread Index | Old Index