Re: checksum argmax fix

[Thomas Klausner <wiz%gatalith.at@localhost>]

On Tue, Aug 06, 2024 at 11:33:34PM +0200, Thomas Klausner wrote:
> On Tue, Aug 06, 2024 at 09:32:12PM +0100, Jonathan Perkin wrote:
> > Ok I've attached a patch that appears to work for me, at least now I'm able
> > to 'bmake checksum' in wip/grafana, though it still doesn't help systems
> > that have older bmake without the temporary file fix.
> > 
> > Note for anyone testing mktool I've also added support for checksums, and
> > the latest version (0.1.8) also now supports -I to match this patch.
> 
> I've tried this on NetBSD-current/amd64 as of July 11, and that make
> is not good enough:
> 
> # make checksum
> => Bootstrap dependency digest>=20211023: found digest-20220214nb1
> make: exec(/bin/sh) failed (Argument list too long)
> *** Error code 1
> 
> Stop.
> make: stopped making "checksum" in /usr/pkgsrc/wip/grafana

I just checked, that make is right from before this commit:

Module Name:    src
Committed By:   sjg
Date:           Thu Jul 11 20:09:16 UTC 2024

Modified Files:
        src/usr.bin/make: compat.c main.c make.h
        src/usr.bin/make/unit-tests: var-op-shell.mk

Log Message:
Compat_RunCommand use tempfile if cmd too big

Extract the logic recently added to Cmd_Exec to handle
long commands via temp file to Cmd_Argv,
so it can also be leveraged by Compat_RunCommand

Reviewed by: christos



which I think is the one that improved this.

If we commit this, we need a plan for NetBSD 9 and 10...
 Thomas