tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Fix mk/fetch/github.mk



On Tue, Feb 13, 2024 at 09:34:36PM +0100, Adam Ciarciński wrote:
> Attaching a version that introduces GITHUB_REF. This also requires a change in mk/fetch/bsd.fetch-vars.mk (GITHUB_TAG -> GITHUB_REF in line 52).
> 
> From what I see, there's too much magic happening at https://github.com/OWNER/REPO/archive end-point. I can't find its description in the REST API guide https://docs.github.com/en/rest?apiVersion=2022-11-28, or maybe I'm too tired to see. So, I suggest we stick to the documented API, or some unexpected things might happen like the one I've encountered with libproxy.

I like that idea better. But can you please add documentation for it as well?
 Thomas


Home | Main Index | Thread Index | Old Index