>> >> I have packages in pkgsrc (not WIP) which actually use hashes as GITHUB_TAG. >> There are 3 of them in geography/opencpn-plugin-* > > > It is seeming like this change, while being part of what will eventually > make sense, has caused a lot of breakage, and was not tested > adequately. > > Therefore, I think the change should be immediately reverted. > > Then, we can talk about what makes sense to change, and a plan to > adjust all the users (actual tags, commit hashes), url2pkg, and perhaps > something else. Attaching a version that introduces GITHUB_REF. This also requires a change in mk/fetch/bsd.fetch-vars.mk (GITHUB_TAG -> GITHUB_REF in line 52). From what I see, there's too much magic happening at https://github.com/OWNER/REPO/archive end-point. I can't find its description in the REST API guide https://docs.github.com/en/rest?apiVersion=2022-11-28, or maybe I'm too tired to see. So, I suggest we stick to the documented API, or some unexpected things might happen like the one I've encountered with libproxy. Kind regards, Adam
Attachment:
github.mk
Description: Binary data