Re: Time to change defaults for PKG_DBDIR

[David Brownlee <abs%absd.org@localhost>]

On Sun, 22 May 2022 at 12:47, Greg Troxel <gdt%lexort.com@localhost> wrote:
>
> David Brownlee <abs%absd.org@localhost> writes:
>
> > We have two older pkg_install variants - the original which will just
> > unconditionally default to /var/db/pkg, and the current compat which
> > overrides any PKG_DBDIR value if /var/db/pkg is present and PKG_DBDIR
> > is not.
>
> And those can be in /usr/pkg/sbin or /sbin.  It seems obvious that the
> new behavior will not only be applied to pkgsrc and thus updated
> /usr/pkg/sbin, but to the included copy in base and then pulled up to 8
> and 9 (assuming this is done before 8 EOL, which seems likely).

Definitely - goal should be to pullup to -9 and -8 (forgot to mention)

> > I'd really prefer to not have to force a new binary package user to
> > read up about and then manually set PKG_DBDIR in pkg_install.conf when
> > there are no binary packages on their system, however I don't want to
> > block this any further, so while I'm listing my preferences in order,
> > I'm happy as long as something is picked:
>
> That's a good point; we do need to have an exit strategy.
>
> > These would be new pkg_install behaviour if /var/db/pkg is present,
> > _empty_, and different from the set/default PKG_DBDIR
> > a) Try to rmdir/unlink (symlink) it, and continue if successful
> > b) Ignore it and continue
> > c) Error out the same as if present and non empty
>
> I think you are laying out 3 options.
>
> I like (a), with "if not successful, goto c".  That cleans up the
> situation (perhaps with a message, perhaps not) and doesn't force a
> failure.  Sounds like that option is reasonable for you and me?  Anybody else?

Yup - "preferences in order" ;-p

I'm also 100% behind a) with failover to c) - it makes the known case
of empty /var/db/pkg safe for for the existing compat code where
possible, and leaves anything more complicated to an active user
decision.

> I think if we can do this, and ensure that all published bulk builds
> with bad PKG_DBDIR settings are withdrawn, we may be able to stamp out
> virtually all user trouble.

Absolutely. Unless any objections I'd like to leave it another few
days to ensure people have a chance to read & digest, then make the
changes?

Thanks

David