Pierre Pronchery <khorben%defora.org@localhost> writes: > Please note this is not bumping anything nor updating references to > cups-base's buildlink3.mk, with an exception for cups-filters where it > would create a circular dependency otherwise. Let me know if it should > be done right away though. I don't quite follow. If you want to make this change, then there needs to be a working cups-base/buildlink3.mk file that refers to cups-base, and all the things that currently include cups/buildink3 need to be changed to refer to cups-base/buildlink3 instead. Basically, after the change, everything has to be consistent and all the things that depend on cups have to build ok. So I think we must not be understanding each other... I also don't follow the patches. You would be basically reimporting cups as cups-base, changing the name, and basically removing the current print/cups adding in its place a meta-package (we don't always put those in meta-packages/, if they are smallish like this, so that's fine). > I have tested this on NetBSD/amd64. Including building everything that currently depends on cups? Well, there are a lot, so a representative sample seems ok, assuming they all have their bl3 references changed, and PKGREVISION bumped. I would think these only need to bl3/depend on cups-base, because they don't use the ABI of cups-filters, and are quite happily not depending on those now. I don't think it is good to add a dependency that is not needed; that will just cause more work and revbumps than is needed. A quick grep shows: ./graphics/darktable/Makefile:.include "../../print/cups/buildlink3.mk" ./lang/openjdk7/Makefile:.include "../../print/cups/buildlink3.mk" ./lang/openjdk8/Makefile:.include "../../print/cups/buildlink3.mk" ./misc/libreoffice/Makefile:.include "../../print/cups/buildlink3.mk" ./print/cups-drivers-Magicolor5440DL/Makefile:.include "../../print/cups/buildlink3.mk" ./print/gtklp/Makefile:.include "../../print/cups/buildlink3.mk" ./print/hplip/Makefile:.include "../../print/cups/buildlink3.mk" ./print/libgnomecups/Makefile:.include "../../print/cups/buildlink3.mk" ./print/libgnomeprint/Makefile:.include "../../print/libgnomecups/buildlink3.mk" ./print/p5-Net-CUPS/Makefile:.include "../../print/cups/buildlink3.mk" ./print/xpp/Makefile:.include "../../print/cups/buildlink3.mk" ./print/py-cups/Makefile:.include "../../print/cups/buildlink3.mk" ./print/qpdfview/Makefile:.include "../../print/cups/buildlink3.mk" ./print/scribus-qt4/Makefile:.include "../../print/cups/buildlink3.mk" ./print/cups-filters/Makefile:.include "../../print/cups/buildlink3.mk" ./wip/chromium/Makefile:#.include "../../print/cups/buildlink3.mk" ./wip/gimmie/Makefile:.include "../../print/libgnomecups/buildlink3.mk" ./wip/hpoj/Makefile:.include "../../print/cups/buildlink3.mk" ./wip/splix/Makefile:.include "../../print/cups/buildlink3.mk" ./wip/libreoffice-git/Makefile:.include "../../print/cups/buildlink3.mk" ./wip/cinnamon-settings-daemon/Makefile:.include "../../print/cups/buildlink3.mk" ./wip/gnome-settings-daemon/Makefile:.include "../../print/cups/buildlink3.mk" ./joyent/openjdk7/Makefile:.include "../../print/cups/buildlink3.mk"
Attachment:
signature.asc
Description: PGP signature