Jonathan Perkin <jperkin%joyent.com@localhost> writes: > * On 2016-02-01 at 18:36 GMT, Richard PALO wrote: > >> I'd like to propose making OS_VARIANT multi-value. >> >> In particular this is useful for SunOS where currently only >> "SmartOS" and "OmniOS" are listed variants but not "Illumos" as a whole. >> >> The basis is simple, if ${OS_VERSION} == "5.11" and there is no "Oracle" found >> in /etc/release, then the OS_VARIANT would be [initially] "Illumos". >> >> Subsequently, "SmartOS" and "OmniOS" can tack onto OS_VARIANT with '+=' instead of '='. > > I don't like the idea of changing the variable type and overloading it > with multiple meanings, but I agree we could do with a way to identify > the different vendors, so maybe just introduce a new variable like we > did with LOWER_VARIANT_VERSION. Maybe OS_VENDOR? I agree, more or less. My big point would be that Someone needs to decide if a proper OS_VARIANT is Illumos or if SmartOS and OmniOS are proper values. With the various forking and branding going on, this seems more important. The other logical point is to have a full-blown hierarchy of names, as an arbitrary tree, but that seems unwarranted. Richard: What problem are you trying to solve, and what are the other candidate approaches?
Attachment:
signature.asc
Description: PGP signature