Re: PKGSRC_SETENV?= ${SETENV} -i

[Taylor R Campbell <campbell+netbsd-tech-pkg%mumble.net@localhost>]

   Date: Mon, 3 Jun 2013 23:40:52 +0000
   From: Taylor R Campbell <campbell+netbsd-tech-pkg%mumble.net@localhost>

   I committed a change to make PKGSRC_SETENV be `env -i' by default.
   This should fix the build breakage of security/openssl in tool
   dependencies that has been broken for far too long (sorry, folks --
   entirely my fault), but it may break various other parts of the world,
   so please let me know if I have broken anything -- or, more likely,
   exposed latent bugs -- by doing this.

So, although I think this change is fundamentally the right idea, it
exposes more issues than I have the time to deal with myself, so I
decided to suggest backing it out unless someone else is willing to
take responsibility for handling all the issues it exposes.  tron@
backed it out already, though, before I got to my email today.

It shouldn't be too hard in principle to fix all the issues that have
been reported.  We just need a list of environment variables that
pkgsrc cares about:

PKGSRC_ENV_VARS+=       ALLOW_VULNERABLE_PACKAGES
PKGSRC_ENV_VARS+=       CFLAGS
PKGSRC_ENV_VARS+=       FETCH_USING
...

.for _var_ in ${PKGSRC_ENV_VARS}
PKGSRC_MAKE_ENV.${_var}:=       ${_var_:D${_var_}=${${_var_}:Q}}
PKGSRC_MAKE_ENV+=               ${PKGSRC_MAKE_ENV.${_var_}}
.endfor

But I don't think I have the time do find and test and otherwise deal
with them all at the moment.