Re: devel/xulrunner and www/seamonkey don't build on NetBSD 5.2_STABLE

[Ryo ONODERA <ryo_on%yk.rim.or.jp@localhost>]

Hi,

From: eric%cirr.com@localhost (Eric Schnoebelen), Date: Thu, 21 Mar 2013 
16:40:41 -0500

> 
> Ryo ONODERA writes:
> - From: eric%cirr.com@localhost (Eric Schnoebelen), Date: Wed, 20 Mar 2013 
> 15:36:26 -0500
> - > I'm trying to update my pkgsrc tree to 2013-03-18 (or there
> - > abouts) and I've found that neither www/seamonkey nor
> - > devel/xulrunner will build, because NetBSD 5.2_STABLE does not
> - > have the function pthread_getattr_np().
> 
> One other thing I noticed while trying to get www/seamonkey to
> build is that it's Makefile (or maybe
> devel/xulrunner/mozilla-common.mk) needs to include
> 
>       GCC_REQD=4.5
> 
> and doesn't.

Thank you.

gcc-4.1.3 from NetBSD 5.2 is not sufficient to build xulrunner anymore
(from xulrunner 18).
gcc45-4.5.3 from pkgsrc/lang/gcc45 does not generate proper binary,
so segfault (build is finished).
gcc46-4.6.3 from pkgsrc/lang/gcc46 works fine.
gcc-4.6.4 from NetBSD current generates proper binary too.

And I cannot reproduce -fPIC error on NetBSD/amd64 5.2_RELEASE.
I will try to build xulrunner on NetBSD/amd64 5.2_SATBLE on nyftp later.


Please try the following patches for pkgsrc/devel/xulrunner.
If the patches are o.k., I will patch seamonkey with similar way.

New patch, patches/patch-ipc_chromium_src_base_platform__thread__posix.cc
$NetBSD$

--- ipc/chromium/src/base/platform_thread_posix.cc.orig 2013-03-07 
10:48:46.000000000 +0000
+++ ipc/chromium/src/base/platform_thread_posix.cc
@@ -10,7 +10,9 @@
 #if defined(OS_MACOSX)
 #include <mach/mach.h>
 #elif defined(OS_NETBSD)
+_Pragma("GCC visibility push(default)")
 #include <lwp.h>
+_Pragma("GCC visibility pop")
 #elif defined(OS_LINUX)
 #include <sys/syscall.h>
 #include <sys/prctl.h>

? patches/patch-ipc_chromium_src_base_platform__thread__posix.cc
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/devel/xulrunner/Makefile,v
retrieving revision 1.98
diff -u -r1.98 Makefile
--- Makefile    22 Feb 2013 14:48:06 -0000      1.98
+++ Makefile    24 Mar 2013 01:35:48 -0000
@@ -2,6 +2,7 @@
 
 .include "dist.mk"
 PKGNAME=       xulrunner-${MOZ_BRANCH}${MOZ_BRANCH_MINOR:S/esr//}
+PKGREVISION=   1
 CATEGORIES=    devel www
 
 MAINTAINER=    pkgsrc-users%NetBSD.org@localhost
@@ -27,8 +28,6 @@
 
 MAKE_ENV+=             FREEBL_NO_DEPEND=0
 
-GCC_REQD+=             4.5
-
 # workround for link of xulrunner-bin etc.
 LDFLAGS+=              ${COMPILER_RPATH_FLAG}${PREFIX}/lib/xulrunner 
${COMPILER_RPATH_FLAG}${PREFIX}/lib
 
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/devel/xulrunner/distinfo,v
retrieving revision 1.96
diff -u -r1.96 distinfo
--- distinfo    10 Mar 2013 00:22:16 -0000      1.96
+++ distinfo    24 Mar 2013 01:35:49 -0000
@@ -23,7 +23,7 @@
 SHA1 (patch-az) = 2012a7fef2eac59f48ff21fea0e205e89b313e46
 SHA1 (patch-ba) = 1692053c1b0e65dd38bcf37cc1a80390cce081eb
 SHA1 (patch-bd) = 1a24cb9e4dc312725d0a6ffdf202b6f3e98d17fb
-SHA1 (patch-bf) = a24b88b0f12bf787d1adee9574404747b29b8a6b
+SHA1 (patch-bf) = ac5689eaec8cc79d5255a692b255de8a8690539a
 SHA1 (patch-bg) = e5af56b3dca81ad67149c09942580ebd9062b38d
 SHA1 (patch-bi) = 3dd927d93431afe000cd4a45b4d9920e63158a85
 SHA1 (patch-build_autoconf_nss.m4) = 4731f46a41f6d4ff31a6da07c9badb328a0f676f
Index: mozilla-common.mk
===================================================================
RCS file: /cvsroot/pkgsrc/devel/xulrunner/mozilla-common.mk,v
retrieving revision 1.43
diff -u -r1.43 mozilla-common.mk
--- mozilla-common.mk   10 Mar 2013 17:27:27 -0000      1.43
+++ mozilla-common.mk   24 Mar 2013 01:35:49 -0000
@@ -12,6 +12,13 @@
 USE_LANGUAGES+=                c99 c++
 UNLIMIT_RESOURCES+=    datasize
 
+.include "../../mk/bsd.prefs.mk"
+# gcc45-4.5.3 of lang/gcc45 does not generate proper binary,
+# but gcc 4.5.4 of NetBSD 7 generates working binary.
+.if !empty(MACHINE_PLATFORM:MNetBSD-5.*)
+GCC_REQD+=             4.6
+.endif
+
 CHECK_PORTABILITY_SKIP+=${MOZILLA_DIR}security/nss/tests/libpkix/libpkix.sh
 CHECK_PORTABILITY_SKIP+=${MOZILLA_DIR}security/nss/tests/multinit/multinit.sh
 CHECK_INTERPRETER_SKIP+=lib/xulrunner-sdk/sdk/bin/xpt.py
Index: patches/patch-bf
===================================================================
RCS file: /cvsroot/pkgsrc/devel/xulrunner/patches/patch-bf,v
retrieving revision 1.10
diff -u -r1.10 patch-bf
--- patches/patch-bf    7 Feb 2013 20:32:42 -0000       1.10
+++ patches/patch-bf    24 Mar 2013 01:35:49 -0000
@@ -1,6 +1,6 @@
 $NetBSD: patch-bf,v 1.10 2013/02/07 20:32:42 ryoon Exp $
 
---- js/src/jsnativestack.cpp.orig      2013-01-16 16:01:13.000000000 +0000
+--- js/src/jsnativestack.cpp.orig      2013-03-07 10:48:48.000000000 +0000
 +++ js/src/jsnativestack.cpp
 @@ -19,13 +19,10 @@
  #elif defined(XP_MACOSX) || defined(DARWIN) || defined(XP_UNIX)
@@ -22,7 +22,7 @@
  #  if defined(__OpenBSD__)
      stack_t ss;
 -#  elif defined(PTHREAD_NP_H) || defined(_PTHREAD_NP_H_) || defined(NETBSD)
-+#  elif defined(PTHREAD_NP_H) || defined(_PTHREAD_NP_H_) || 
defined(__DragonFly__)
++#  elif defined(PTHREAD_NP_H) || defined(_PTHREAD_NP_H_) || 
defined(__DragonFly__) || defined(NETBSD) || defined(__NetBSD__) /* XXX tnn not 
sure why NETBSD isn't defined, it looks like it should be ... */
      /* e.g. on FreeBSD 4.8 or newer, neundorf%kde.org@localhost */
      pthread_attr_get_np(thread, &sattr);
  #  else

--
Ryo ONODERA // ryo_on%yk.rim.or.jp@localhost
PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3