devel/xulrunner and www/seamonkey don't build on NetBSD 5.2_STABLE

[eric%cirr.com@localhost (Eric Schnoebelen)]

I'm trying to update my pkgsrc tree to 2013-03-18 (or there
abouts) and I've found that neither www/seamonkey nor
devel/xulrunner will build, because NetBSD 5.2_STABLE does not
have the function pthread_getattr_np().

In looking at js/src/jsnativestack.cpp, I see there is a
preprocessor path that uses pthread_attr_get_np(), which is
supported on NetBSD 5.2_STABLE.

In both packages, there is a patch (patch-bf) that modifies this
file.  It looks like a simple change of adding ``||
defined(__NetBSD__)'' to the second #elif in the second block of
the patch should be able to resolve the problem.

And after a test build, I find that it the above change (also
attached as a patch) allows devel/xulrunner to compile past this
point on NetBSD 5.2_STABLE (it now dies in a different location
complaining of needing -fPIC, investigating.)

Any reasons not to apply this patch?

Thanks

--
Eric Schnoebelen                eric%cirr.com@localhost         
http://www.cirr.com
      "...we have normality"..."Anything you still can't cope with is
          therefore your own problem..." -- Tricia McMillian, HHGG

Index: patches/patch-bf
===================================================================
RCS file: /cvsroot/pkgsrc/devel/xulrunner/patches/patch-bf,v
retrieving revision 1.10
diff -b -u -w -r1.10 patch-bf
--- patches/patch-bf    7 Feb 2013 20:32:42 -0000       1.10
+++ patches/patch-bf    20 Mar 2013 20:35:53 -0000
@@ -22,7 +22,7 @@
  #  if defined(__OpenBSD__)
      stack_t ss;
 -#  elif defined(PTHREAD_NP_H) || defined(_PTHREAD_NP_H_) || defined(NETBSD)
-+#  elif defined(PTHREAD_NP_H) || defined(_PTHREAD_NP_H_) || 
defined(__DragonFly__)
++#  elif defined(PTHREAD_NP_H) || defined(_PTHREAD_NP_H_) || 
defined(__DragonFly__) || defined(__NetBSD__)
      /* e.g. on FreeBSD 4.8 or newer, neundorf%kde.org@localhost */
      pthread_attr_get_np(thread, &sattr);
  #  else