tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: fixing bugs in packages



> On Sun, May 13, 2012 at 3:44 AM, Joerg Sonnenberger
> <joerg%britannica.bec.de@localhost> wrote:
 >> On Sat, May 12, 2012 at 02:58:51PM +0300, Aleksey Cheusov wrote:
 >>> >>> for example. Some time ago, I proposed the same here and still have
 >>> >>> "rebuild" target in my mk.conf.
 >>> >>
 >>> >> A quick search did not find it, could you please share it (again)?
 >>> >> Thanks,
 >>> > The attached patch implements "rebuild" target and I think

 >> Incomplete. Doesn't handle package. Also should likely kill .destdir and
 >> the various PLIST check files. I'm not completely sure about the
 >> post-barrier implications for this either.

> Updated patch is in attachment.

I also would like to add a "retest" target often used when I work
on packages with sources under files/ (e.g. wip/pkg_summary-utils).

Use pattern:

   while (!enough){
      add more tests;
      change existing tests;
      make retest;
   }

Patch is below.

Index: build/test.mk
===================================================================
RCS file: /cvsroot/pkgsrc/mk/build/test.mk,v
retrieving revision 1.17
diff -u -r1.17 test.mk
--- build/test.mk       2 May 2012 13:44:27 -0000       1.17
+++ build/test.mk       19 May 2012 07:57:14 -0000
@@ -86,6 +86,15 @@
 .endif
 
 ######################################################################
+### retest (PUBLIC)
+######################################################################
+### retest is a special target to re-run the test target.
+###
+.PHONY: retest
+retest: test-clean
+       ${RUN} ${RECURSIVE_MAKE} ${MAKEFLAGS} test
+
+######################################################################
 ### real-test (PRIVATE)
 ######################################################################
 ### real-test is a helper target onto which one can hook all of the
@@ -164,3 +173,13 @@
        ${RUN}${TEST} ! -f ${_COOKIE.test} || ${FALSE}
        ${RUN}${MKDIR} ${_COOKIE.test:H}
        ${RUN}${ECHO} ${PKGNAME} > ${_COOKIE.test}
+
+######################################################################
+### test-clean (PRIVATE)
+######################################################################
+### test-clean removes the state files for the "test" and
+### later phases so that the "test" target may be re-invoked.
+###
+.PHONY: test-clean
+test-clean:
+       ${RUN} ${RM} -f ${_COOKIE.test}

-- 
Best regards, Aleksey Cheusov.


Home | Main Index | Thread Index | Old Index