Re: CVS commit: pkgsrc/audio/tunapie

[Hans Rosenfeld <rosenfeld%grumpf.hope-2000.org@localhost>]

On Thu, Feb 16, 2012 at 04:58:49PM +0100, Joerg Sonnenberger wrote:
> On Thu, Feb 16, 2012 at 04:40:49PM +0100, Hans Rosenfeld wrote:
> > On Thu, Feb 16, 2012 at 04:27:13PM +0100, Joerg Sonnenberger wrote:
> > > On Thu, Feb 16, 2012 at 02:29:18PM +0100, Hans Rosenfeld wrote:
> > > > So you suggest adding a check in the infrastructure that finds shell
> > > > scripts, and replaces the interpreter automatically if needed?
> > > > 
> > > > There already is something like that in place that checks for
> > > > non-existant interpreters, and I have a patch that extends this to check
> > > > for /bin/sh on Solaris. I could probably extend it further to
> > > > automatically replace it with TOOLS_PATH.sh or something like that.
> > > > 
> > > > Would that be better?
> > > 
> > > You could just set REPLACE_SH= * */* */*/* on Solaris by default.
> > 
> > Hm, really? Wouldn't that cause quite some overhead?
> 
> At the moment, it would do one sed per source file. That's not optimal,
> but that shouldn't hurt too much. Not sure how to optimize this using
> shell tools only.

I just checked it with qt4-libs, and it adds about 30s run time here.
Thats not much, but I think that could easily add up, especially if
extended to */*/*/* or */*/*/*/* :)

I think it could also interfere with REPLACE_BASH, and it'll add
overhead to packages that don't need it. So I'll probably try to do it
in check-interpreter.mk.


Hans


-- 
%SYSTEM-F-ANARCHISM, The operating system has been overthrown