tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: pkgsrc/audio/tunapie



On Thu, Feb 16, 2012 at 02:29:18PM +0100, Hans Rosenfeld wrote:
> On Thu, Feb 16, 2012 at 01:16:15PM +0100, Joerg Sonnenberger wrote:
> > On Thu, Feb 16, 2012 at 11:12:12AM +0100, Hans Rosenfeld wrote:
> > > Besides, why is it a good idea to use REPLACE_BASH etc. but not to do the
> > > same with REPLACE_SH?
> > 
> > REPLACE_BASH is the exception, not the rule. It doesn't make sense to
> > change every single package that installs shell scripts as they can be
> > detected reliably and automated. If it is a real problem that has to be
> > solved everywhere, it should be solved in the infrastructure and not
> > make everything slightly more complicated.
> 
> So you suggest adding a check in the infrastructure that finds shell
> scripts, and replaces the interpreter automatically if needed?
> 
> There already is something like that in place that checks for
> non-existant interpreters, and I have a patch that extends this to check
> for /bin/sh on Solaris. I could probably extend it further to
> automatically replace it with TOOLS_PATH.sh or something like that.
> 
> Would that be better?

You could just set REPLACE_SH= * */* */*/* on Solaris by default.

Joerg


Home | Main Index | Thread Index | Old Index