Re: why is replace.mk complaining about gsed?

[John Marino <marino%netbsd.org@localhost>]

On 12/9/2011 3:53 AM, OBATA Akio wrote:
> On Fri, 09 Dec 2011 10:58:26 +0900, John Marino <marino%netbsd.org@localhost> 
> wrote:
>
> > > I cannot find gsed in USE_TOOLS for emacs20...?
> > > (I may see same problem if USE_TOOLS is changed during some make phase)
> > No, me neither.  gsed isn't used.  There's something going on with this
> > replacement.mk.
> >
> > Do you know why these variables are not wrapped in double quotes?  If 
> > they
> > were, we would not be seeing these errors when the variables are 
> > undefined.
>
> Because if gsed is in USE_TOOLS, _TOOLS_DEPMETHOD.gsed should be set as
> one of BOOTSTRAP_PDENEDS, BUILD_DEPENDS or DEPENDS (lines 134-142).
The problem is that _USE_TOOLS:Mgsed is not empty but _USE_TOOLS:Mgsed 
is.  This
clearly was not expected by the person that wrote this makefile.  It's 
also happening
with different package makefiles on different USE_TOOLS, and there 
doesn't seem to be
 anything wrong / weird with the package makefiles themselves.

So again: Since it clearly *IS* possible that _TOOLS_DEPMETHOD.<class> 
can arrive at
these condition switches as empty strings, then double quotes must be 
used here.  Even
if _TOOLS_DEPMETHOD.<class> being empty is itself a bug, at least it 
won't crash the
package.