Re: package maintainers vs owners

[David Brownlee <abs%NetBSD.org@localhost>]

On Mon, 28 Apr 2008, David Brownlee wrote:

>         Some package maintainers would like anyone else who wants to
>         change the package to check with them first, while others are
>         happy to have anyong update the package, but are available as
>         a "in case you have questions" facility.
>
>         I'd like to suggest we add a new pkgsrc value "OWNER" for
>         the first, and leave MAINTAINER for the second.

        Since no-one has objected to this and I've had several positive
        responses I'd like to propose the below changes to pkgsrc/mk
        and pkgsrc/doc:

        Effectively bsd.pkg.mk will set MAINTAINER from OWNER if
        necessary but otherwall all logic and file formats remain
        unchanged.


Index: mk/bsd.pkg.mk
===================================================================
RCS file: /cvsroot/pkgsrc/mk/bsd.pkg.mk,v
retrieving revision 1.1941
diff -u -r1.1941 bsd.pkg.mk
--- mk/bsd.pkg.mk       3 Apr 2008 14:07:51 -0000       1.1941
+++ mk/bsd.pkg.mk       21 May 2008 09:56:38 -0000
@@ -102,7 +102,7 @@
 DEPENDS?=              # empty
 DESCR_SRC?=            ${PKGDIR}/DESCR
 INTERACTIVE_STAGE?=    none
-MAINTAINER?=           pkgsrc-users%NetBSD.org@localhost
+MAINTAINER?=           ${OWNER:Upkgsrc-users%NetBSD.org@localhost}
 PKGWILDCARD?=          ${PKGBASE}-[0-9]*
 SVR4_PKGNAME?=         ${PKGNAME}
 WRKSRC?=               ${WRKDIR}/${DISTNAME}
Index: doc/Makefile-example
===================================================================
RCS file: /cvsroot/pkgsrc/doc/Makefile-example,v
retrieving revision 1.16
diff -u -r1.16 Makefile-example
--- doc/Makefile-example        4 Jan 2008 19:53:36 -0000       1.16
+++ doc/Makefile-example        21 May 2008 09:56:40 -0000
@@ -10,7 +10,7 @@
 MASTER_SITES=          ${MASTER_SITE_GNU:=make/}
 #EXTRACT_SUFX=         .tar.bz2        # .tar.gz is the default, only needed 
in unusual circumstances

-# Second paragraph - MAINTAINER, HOMEPAGE and COMMENT
+# Second paragraph - MAINTAINER/OWNER, HOMEPAGE and COMMENT
 MAINTAINER=            pkgsrc-users%NetBSD.org@localhost       # set this to 
your email address, pkgsrc-users@ is the default
 HOMEPAGE=              http://www.gnu.org/software/make/make.html
 COMMENT=               GNU version of 'make' utility   # start with a capital, 
no articles at start
Index: doc/guide/files/components.xml
===================================================================
RCS file: /cvsroot/pkgsrc/doc/guide/files/components.xml,v
retrieving revision 1.38
diff -u -r1.38 components.xml
--- doc/guide/files/components.xml      2 Jan 2008 14:20:55 -0000       1.38
+++ doc/guide/files/components.xml      21 May 2008 09:56:41 -0000
@@ -96,16 +96,24 @@
   <para>The third section contains the following variables.
   <itemizedlist>

-    <listitem><para><varname>MAINTAINER</varname> is the email address
-    of the person who feels responsible for this package, and who is
-    most likely to look at problems or questions regarding this
-    package which have been reported with &man.send-pr.1;. Other
-    developers should contact the <varname>MAINTAINER</varname> before
-    making major changes to the package. When packaging a new program,
-    set <varname>MAINTAINER</varname> to yourself. If you really can't
-    maintain the package for future updates, set it to
+    <listitem><para><varname>MAINTAINER</varname> is the email
+    address of the person who feels responsible for this package,
+    and who is most likely to look at problems or questions regarding
+    this package which have been reported with &man.send-pr.1;.
+    Other developers may contact the <varname>MAINTAINER</varname>
+    before making changes to the package, but are not required to
+    do so. When packaging a new program, set <varname>MAINTAINER</varname>
+    to yourself. If you really can't maintain the package for future
+    updates, set it to
     <email>pkgsrc-users%NetBSD.org@localhost</email>.</para></listitem>

+    <listitem><para><varname>OWNER</varname> should be used instead
+    of <varname>MAINTAINER</varname> when you do not want other
+    developers to update or change the package without contacting
+    you first. A package Makefile should contain one of
+    <varname>MAINTAINER</varname> or <varname>OWNER</varname>, but
+    not both.  </para></listitem>
+
     <listitem><para><varname>HOMEPAGE</varname> is a URL where users can
     find more information about the package.</para></listitem>

Index: doc/guide/files/fixes.xml
===================================================================
RCS file: /cvsroot/pkgsrc/doc/guide/files/fixes.xml,v
retrieving revision 1.92
diff -u -r1.92 fixes.xml
--- doc/guide/files/fixes.xml   23 Jan 2008 13:46:21 -0000      1.92
+++ doc/guide/files/fixes.xml   21 May 2008 09:56:42 -0000
@@ -586,7 +586,8 @@
     <varname>PKGREVISION</varname> are:</para>

     <itemizedlist><listitem>
-      <para>Changing <varname>HOMEPAGE</varname>, 
<varname>MAINTAINER</varname>,
+      <para>Changing <varname>HOMEPAGE</varname>,
+      <varname>MAINTAINER</varname>, <varname>OWNER</varname>,
       or comments in Makefile.</para></listitem><listitem><para>
       Changing build variables if the resulting binary package is the 
same.</para></listitem><listitem><para>
       Changing <filename>DESCR</filename>.</para></listitem><listitem><para>
--
                David/absolute       -- www.NetBSD.org: No hype required --