tech-net archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: axe(4) AX88772B extensions pullup to 6



On Thu, 3 Jan 2013, at 22:57:46 +0100, Edgar Fuß wrote:
>I recently acquired some Asix AX88772B-based USB Ethernet adapters
>that axe(4) would not support in 6.0, yet fortunately it did in
>-current.  I adapted the changes in -current needed to support the
>772B with minimal changes to 6.0, please find them attached.
>Could they be pulled up so 6.1 will support these devices?

Hello,

(I'd requested the same in PR 47245.)  Note that there's an error in
the patches originally submitted and committed which is replicated
in your patches, see my response in PR 47245, it's:

--- if_axe.c.orig       2012-12-05 22:02:51.000000000 -0500
 +++ if_axe.c   2012-12-05 22:04:36.000000000 -0500
 @@ -929,7 +929,7 @@
                                goto done;
                        }

 
 -                      rxlen = le16toh(hdr.len & AXE_RH1M_RXLEN_MASK);
 +                      rxlen = le16toh(hdr.len) & AXE_RH1M_RXLEN_MASK;
                        if (total_len < rxlen) {
                                pktlen = total_len;
                                total_len = 0;

Regards,

Dave


Home | Main Index | Thread Index | Old Index