tech-net archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: apparently missing locking in if_bnx.c

On Tue, Mar 06, 2012 at 06:53:42AM -0500, Beverly Schwartz wrote:
> I was using the tip of netbsd-6.  I can test it again to be sure.

You should add tests to make sure that:
- bnx_start() is always called at splnet():
  KASSERT(curcpu()->ci_level >= IPL_NET);
- bnx_start() is always called with KERNEL_LOCK held:
  KASSERT(ci->ci_biglock_count > 0);

Manuel Bouyer <>
     NetBSD: 26 ans d'experience feront toujours la difference

Home | Main Index | Thread Index | Old Index