Re: Another update for axe(4)

[Paul Goyette <paul%whooppee.com@localhost>]

On Tue, 15 Jun 2010, FUKAUMI Naoki wrote:

> hi,
>
> thank you for your work!

No problem - I needed to do it anyway because I needed to make my 
AX88772 device work!  Thanks for your work on the mii stuff - we should 
be able to get that working fairly soon.

> > > - in axe_init(), no need to set AXE_RXCMD_PROMISC and
> > > AXE_RXCMD_BROADCAST individually.
> >
> > Is the following correct?
> >
> > /* If we want promiscuous mode, set the allframes bit. */
> > if (ifp->if_flags & (IFF_PROMISC | IFF_BROADCAST))
> > rxmode |= AXE_RXCMD_PROMISC |AXE_RXCMD_BROADCAST;
>
> sorry, AXE_RXCMD_PROMISC is handled in axe_setmulti(), and 
> AXE_RXCMD_BROADCAST is handled few lines above in axe_init().

OK, so the following portion of axe_setmulti() is correct?

        /* If we want promiscuous mode, set the allframes bit */
        if (ifp->if_flags & IFF_PROMISC) {
                rxmode |= AXE_RXCMD_PROMISC;
                goto allmulti;
        }


> > > - in axe_ioctl(), call ifioctl_common() at first in SIOCSIFFLAGS case.
> >
> > Do you mean to call ether_ioctl()? Is the following correct?
>
> see if_aue.c:aue_ioctl:SIOCSIFFLAGS for example.

Ah, OK, got it!


-------------------------------------------------------------------------
| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:       |
| Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com    |
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net |
| Kernel Developer |                          | pgoyette at netbsd.org  |
-------------------------------------------------------------------------