Re: Another update for axe(4)

[FUKAUMI Naoki <fun%naobsd.org@localhost>]

hi,

thank you for your work!

On 06/15/10 22:08, Paul Goyette wrote:
> > - in axe_init(), no need to set AXE_RXCMD_PROMISC and
> > AXE_RXCMD_BROADCAST individually.
>
> Is the following correct?
>
> /* If we want promiscuous mode, set the allframes bit. */
> if (ifp->if_flags & (IFF_PROMISC | IFF_BROADCAST))
> rxmode |= AXE_RXCMD_PROMISC |AXE_RXCMD_BROADCAST;

sorry, AXE_RXCMD_PROMISC is handled in axe_setmulti(), and 
AXE_RXCMD_BROADCAST is handled few lines above in axe_init().

> > - in axe_ioctl(), call ifioctl_common() at first in SIOCSIFFLAGS case.
>
> Do you mean to call ether_ioctl()? Is the following correct?

see if_aue.c:aue_ioctl:SIOCSIFFLAGS for example.

Regards,

--
FUKAUMI Naoki