tech-net archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys


thanks for working on this.

> Module Name:  src
> Committed By: darran
> Date:         Fri May 29 04:57:05 UTC 2009
> Modified Files:
>       src/sys/dev/pci: if_wm.c
>       src/sys/net: if_ethersubr.c
>       src/sys/net/agr: ieee8023ad_lacp.c if_agr.c if_agrether.c
>           if_agrvar_impl.h
> Log Message:
> Add vlan support and hardware offload capabilities to agr.
> These changes allow vlans to be layered above agr, with the attach
> and detach propogated to the member ports in the aggregation.
> Note the agr interface must be up before the vlan is attached.
> Adds SIOCINITIFADDR support to the wm driver for setting the AF_LINK
> address, necessary for agr to be able to set the mac addresses of each
> port to the agr address (i.e. so it can receive all intended traffic
> at the hardware level).
> Adds support for disabling the LACP protocol by setting LINK1 on the agr
> interface (e.g. ifconfig agr0 link1).

i'm not happy with using link1 for the purpose.
1 bit is not enough to specify a configuration mechanism.
IMO it should be able to be specified with a string like
"lacp" "static" etc.  (or probably with a plist with configuration
mechanism specific parameters like port priority etc.)

> In consultation with tls@.
> To generate a diff of this commit:
> cvs rdiff -u -r1.174 -r1.175 src/sys/dev/pci/if_wm.c
> cvs rdiff -u -r1.171 -r1.172 src/sys/net/if_ethersubr.c
> cvs rdiff -u -r1.8 -r1.9 src/sys/net/agr/ieee8023ad_lacp.c

i'm not happy with using _lacp.c file for static configuration.
with static configuration, the lacp state machine should not run
in the first place.

> cvs rdiff -u -r1.22 -r1.23 src/sys/net/agr/if_agr.c


> cvs rdiff -u -r1.6 -r1.7 src/sys/net/agr/if_agrether.c

as your comment suggets, capability should be intersection of
underlying ports.  what's wrong with doing it in _portinit/portfini?


> cvs rdiff -u -r1.7 -r1.8 src/sys/net/agr/if_agrvar_impl.h
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.

Home | Main Index | Thread Index | Old Index