Re: Remove VFS_SYNC in dounmount()

[manu%netbsd.org@localhost (Emmanuel Dreyfus)]

Thor Lancelot Simon <tls%panix.com@localhost> wrote:

> I objected the last time you brought it up.

You refer to this?

> It's not required to, but I am glad it does.  How else can you actually
> know all the buffers hit the disk before you hit the power switch?

As noted by Chuck in the meantime, VFS_UNMOUNT() also flushes data (with
the knowledge of wether this is a forced unmount or not), and nothing
seems to prevent new dirty data to be added between the VFS_SYNC() and
VFS_UNMOUNT().

This suggests the VFS_SYNC() just duplicates the flush operation, adding
delay because it does not know about force unmount, and without any real
benefit.

-- 
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu%netbsd.org@localhost