Re: Remove VFS_SYNC in dounmount()

[Thor Lancelot Simon <tls%panix.com@localhost>]

On Tue, Jul 14, 2015 at 06:58:27PM +0200, Emmanuel Dreyfus wrote:
> Emmanuel Dreyfus <manu%netbsd.org@localhost> wrote:
> 
> > Anyone has an idea why we need this VFS_SYNC() before VFS_UNMOUNT() in
> > dounmount()? As noted by Chuck below, this seems to just duplicate
> > functionality. And it is at the expense of disturbing force unmount
> > since the VFS_SYNC ignoes the MNT_FORCE flags and can make us wait for a
> > while.
> 
> No complain on this, anyone? I tested removing this VFS_SYNC(), and NFS
> force umount now respond faster without other processes hanging in
> tstile until it is done. 

I objected the last time you brought it up.

> Shall I commit it?

Not unless it's conditionalized so it only happens if the umount is forced.

Thor