tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

re: Remove VFS_SYNC in dounmount()



Emmanuel Dreyfus writes:
> Emmanuel Dreyfus <manu%netbsd.org@localhost> wrote:
> 
> > Anyone has an idea why we need this VFS_SYNC() before VFS_UNMOUNT() in
> > dounmount()? As noted by Chuck below, this seems to just duplicate
> > functionality. And it is at the expense of disturbing force unmount
> > since the VFS_SYNC ignoes the MNT_FORCE flags and can make us wait for a
> > while.
> 
> No complain on this, anyone? I tested removing this VFS_SYNC(), and NFS
> force umount now respond faster without other processes hanging in
> tstile until it is done. 
> 
> Shall I commit it?

please wait at least a week, if not 2 or 3, before commiting this
potentially dangerous change, for other comments.


.mrg.


Home | Main Index | Thread Index | Old Index