tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Dealing with debugging macros for printing as part of aprint clean-up



In article <20150208103806.GA1632%norite.fritz.box@localhost>,
Izaak  <yitzhak%inbox.ru@localhost> wrote:
>Hi,
>
>Sorry for my silence on the aprint project. I was busy in the last
>while, but I have more time to dedicate to it now.
>
>Anyway, I am currently working on the first task, converting printf to
>the appropriate aprint during autoconfiguration. Having read through
>many files, I have found that often printf is wrapped in a macro like
>'DPRINTF', which is occasionally used both in the driver attachment
>function and also elsewhere in the file. I am not sure whether to
>replace the 'printf' inside the macro; make a new macro just for
>attachment; replace the macro with a direct call to an aprint function.
>Also, some macros contain uprintf, ttyprintf or tprintf (e.g.
>/sys/dev/acpi/acpi_apm.c) -- Martin told me to leave those intact. I
>suppose this question holds also for general macro usage, so what is the
>best way to deal with that?

I think it is best to leave them alone too for now...

christos



Home | Main Index | Thread Index | Old Index