tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Problem in msdosfs_moutfs

While we are here...
(Sorry, I'm too busy with other things, otherwise I'd do it myself.)

I found that msdosfs mount fails for some pre-formatted USB thumb drives
due to a too strict bpb check. See attachment, but it might make sense
to find another limit, or to kill pm_SecPerTrack completely.
Aiui, the <=63 limit makes only sense if the file system is used to
boot from, without int13 extensions. One can safely assume that a PC
with USB ports also implements int13 extensions...

best regards

Forschungszentrum Juelich GmbH
52425 Juelich
Sitz der Gesellschaft: Juelich
Eingetragen im Handelsregister des Amtsgerichts Dueren Nr. HR B 3498
Vorsitzender des Aufsichtsrats: MinDir Dr. Karl Eugen Huthmacher
Geschaeftsfuehrung: Prof. Dr.-Ing. Wolfgang Marquardt (Vorsitzender),
Karsten Beneke (stellv. Vorsitzender), Prof. Dr.-Ing. Harald Bolt,
Prof. Dr. Sebastian M. Schmidt

# HG changeset patch
# Parent 57c15f727f2caa91ee4cac3bc51096ef5b311b40
diff -r 57c15f727f2c -r 62d8682d656d sys/fs/msdosfs/msdosfs_vfsops.c
--- a/sys/fs/msdosfs/msdosfs_vfsops.c   Thu Feb 06 18:37:08 2014 +0100
+++ b/sys/fs/msdosfs/msdosfs_vfsops.c   Thu Jun 05 19:50:47 2014 +0200
@@ -556,7 +556,7 @@
        if (!(argp->flags & MSDOSFSMNT_GEMDOSFS)) {
                /* XXX - We should probably check more values here */
                if (!pmp->pm_BytesPerSec || !SecPerClust
-                       || pmp->pm_SecPerTrack > 63) {
+                       /*|| pmp->pm_SecPerTrack > 63*/) {
                        DPRINTF(("bytespersec %d secperclust %d "
                            "secpertrack %d\n", 
                            pmp->pm_BytesPerSec, SecPerClust,

Home | Main Index | Thread Index | Old Index