Re: src/sys/vfs

[David Laight <david%l8s.co.uk@localhost>]

On Mon, Jul 16, 2012 at 01:57:17AM +0100, Mindaugas Rasiukevicius wrote:
> 
> Please create a branch for this work.  Otherwise, it will be the same
> as with quota changes which were practically unreviewable.  It might
> also be worth to do some mechanical split and move of the related code
> into a new directory first and then create a branch.  So the final diff
> would contain some visible divergence, rather than huge - and + blocks.

Doing development on a branch create its own problems.

If the branch is long lived (or enyonw else is likely to change
any of the affected files) then is is a continual merge problem.

When the branch is finally merged the sequence of changes disappears
from the main cvs changes sequence (yes, I know you can go and look
at the branch changes, but they tend to be out of sequence).

If changes are incrememntal (which this one probably is), then there
is no real problem applying each change to cvs separately - the system
should still build after each.

This is what dh did with the namei changes - a whole series of commits.
(Probably a lot more work because he managed to commit multiple changes
to the same files quite clode together.)

        David

-- 
David Laight: david%l8s.co.uk@localhost