Re: xorg pci probing

[der Mouse <mouse%Rodents-Montreal.ORG@localhost>]

>>> pci_device_is_boot_vga()
>> [...]
> While X is probing the pci devices the driver enables all pci vga
> devices.  That is why checking for the 'firmware enabled' one fails.

But checking for "the" firmware-enabled one is a broken idea.  There
may fewer or more than one such, for one thing - nothing says the
firmware has to initialize any displays; nothing says it has to
initialize no more than one.

And it's a check X shouldn't be doing anyway.  Doing bus enumeration in
userland is insane; that's what we've got kernels for.  X should be
using the device - or devices - it's told to use; if not told anything
about what device to use, it should be picking a sensible default, like
the console (not necessarily boot) device, without caring about others.
I can, sort of, see doing direct access to the display as a PCI device
(_of course_ every display will be a PCI device!), but in no
circumstance can I see any excuse for poking at devices it isn't going
to use or walking all of any bus.

/~\ The ASCII                             Mouse
\ / Ribbon Campaign
 X  Against HTML                mouse%rodents-montreal.org@localhost
/ \ Email!           7D C8 61 52 5D E7 2D 39  4E F1 31 3E E8 B3 27 4B