Re: should gpio be moved to sys/dev from sys/sys?

[Marc Balmer <marc%msys.ch@localhost>]

Am 17.08.2009 um 19:29 schrieb Matt Thomas:

> On Aug 17, 2009, at 10:19 AM, Marc Balmer wrote:
> > Am 17.08.2009 um 18:58 schrieb Matt Thomas:
> > > A device which must exports things to userland (ioctls, defines)  
> > > should only
> > > do so from a file which contain those parts only.  Only this file  
> > > may be placed
> > > under /usr/include.  The driver should include said file to get  
> > > access to those bits.
> > >
> > > This is just following the simple rules of separating interface  
> > > from implementation.
> > >
> > > Having said that, given <sys/gpio.h> is already in netbsd 5, it's  
> > > too late to move.
> >
> > Actually I think sys/gpio.h is at the right place, but dev/ 
> > keylock.h is not.  dev/keylock.h should actually be split into two  
> > files, one containing the internal parts, dev/keylock.h, and one  
> > containing the public parts in sys/keylock.h
>
> dev/keylock.h - public
> dev/keylockvar.h - private
>
> No reason to move it into sys.  Let's try to keep devices out of sys.

Maybe the more important part being files be split into private/public  
parts than where they reside.

keylock, btw, is not a device, like gpio or audio are not strictly  
devices.  They are mere abstractions, no hardware associated with  
those.  They rely, however, on actual device drivers to work.