tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: rfc: high-resolution timer framework

In article <>,
Alexander Shishkin  <> wrote:
>On Mon, Jul 14, 2008 at 08:15:57PM +0000, Christos Zoulas wrote:
>> You mean like this:
>Well, it doesn't apply against current HEAD so not exactly like this. :)
>Please find a couple of comments and a fixed patch [1] below.
>> #if (__FreeBSD_version > 300000)
>> -/* hzto() is removed from FreeBSD-3.0 */
>> -static int hzto(struct timeval *);
>> +/* tvhzto() is removed from FreeBSD-3.0 */
>The comment still stands for hzto(). I'm not sure if it is even needed


>> +#define TV2NS(x) (((uint64_t)(x)->tv_sec) * 1000000000 + (x)->tv_nsec)
>Shouldn't this be TS2NS()? It might also be a good idea to make this
>macro available via sys/time.h or something similar, might it not?

Yes, perhaps. I will rename and move.

>You also seem to have missed the occurence of hzto() in dev/ic/isp_netbsd.c.

I forgot to make the diff...

Thanks, I will take a look.


Home | Main Index | Thread Index | Old Index