[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: CVS commit: src/sys
On Wed, Jan 07, 2009 at 09:05:54PM +0000, Andrew Doran wrote:
> On Sun, Jan 04, 2009 at 06:33:50PM +1100, matthew green wrote:
> > and this change just scares me, that you commited it without
> > fixing the underlying bug or talking about it with anyone
> > else that i can see:
> > ! a.bp = geteblk(2 * (int)lp->d_secsize);
> > -
> > ! /*
> > ! * XXX somehow memory is getting corrupted on 2048 byte sectors if
> > its
> > ! * just 2 times 2048!! It even reads only 2048 bytes max in one go
> > on
> > ! * optical media.
> > ! */
> > !
> > ! a.bp = geteblk(3 * (int)lp->d_secsize);
> This is the second time in recent months you've hammered in a hack around
> I/O buffers. Hacks like this are unacceptable because you have left it for
> someone else to come along and untangle the resulting mess later. This
> change could sit for years because noone but you knows why it is needed.
I apologise for both; they were in hindsight prematurely committed and needed
more investigation and consulting. Its on my TODO list though to see what is
causing it, could be as simple as geteblk() returning a too small block for
> Please diagnose problems and fix them properly. If you run into a brick wall
> diagnosing a problem, ask for assistance with debugging it.
I'll sure do, i stand corrected!
thanks for the feedback,
Main Index |
Thread Index |