Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

re: CVS commit: src/sys

   Module Name: src
   Committed By:        reinoud
   Date:                Tue Dec 30 19:38:36 UTC 2008
   Modified Files:
        src/sys/dev/scsipi: cd.c
        src/sys/kern: subr_disk_mbr.c
        src/sys/sys: disklabel.h
   Log Message:
   Add ISO partition detection enabling auto-detection of iso9660 and UDF
   partitions on optical media like CD/DVD/BD but also on all other media if
   there is no NetBSD disklabel or MBR label.
   Also fix cd's readdisklabel arguments so the ioctl's arrive at the right
   device (!) and update its default label to make more sense.

i'm not so sure about this change:

!       lp->d_partitions[RAW_PART].p_fstype = FS_ISO9660;
!       lp->d_partitions[RAW_PART].p_fstype = FS_UDF;

or the part about changing readdisklabel().  this change needs
to be tested on sun disklabled media, and at least a few of the
other platforms as well.

and this change just scares me, that you commited it without
fixing the underlying bug or talking about it with anyone 
else that i can see:

!       a.bp = geteblk(2 * (int)lp->d_secsize);
!       /*
!        * XXX somehow memory is getting corrupted on 2048 byte sectors if its
!        * just 2 times 2048!! It even reads only 2048 bytes max in one go on
!        * optical media.
!        */
!       a.bp = geteblk(3 * (int)lp->d_secsize);


Home | Main Index | Thread Index | Old Index