Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/usr.bin/make

On Mon, Dec 01, 2008 at 04:59:47PM +0100, Quentin Garnier wrote:
> Fixing this obvious bug makes the build start for me:
> !       accumFor.vars = bmake_realloc(accumFor.vars, nvars * sizeof(char *));
> !       accumFor.vars[nvars] = make_str(data, len);
> But I don't see how that could have survived any kind of testing, so I'm
> not fixing the "fix" before you check that the rest is correct.

I've just realised why it worked for me.
I've some local code to instrument bmake_malloc() which adds a 20/24
byte trailer onto each malloced area.
But I never got around to doing anything with the saved info.

In particular that changes the realloc(NULL, 0) to realloc(NULL, 24)
so the return value isn't NULL!


David Laight:

Home | Main Index | Thread Index | Old Index